[Ffmpeg-devel] [PATCH] cosmetics - reorder bswap.h

Ramiro Ribeiro Polla ramiro
Wed Apr 25 03:08:56 CEST 2007


Ramiro Ribeiro Polla wrote:
> Hello,
>
> Attached patches reorder bswap.h to remove code duplication.
>
> bswap.h.returnx.diff makes 2 functions "return x;" to simplify next 
> patch.

Sorry, that patch was wrong. bswap.h.returnx_2.diff does it correctly.

> bswap.h.reorder.diff reorders bswap functions into bit-depth, 
> special-casing inside the functions.

Updated patch bswap.h.reorder_2.diff, with newly acquired blackfin bswap_32.

>
> They remove 949 bytes from bswap.h =)
>
> The file could then use some prettyprinting to make all asm statements 
> consistent in shape, and use 4 space indentations.
>
> Regression tests "pass" on P4 with HAVE_BYTESTREAM_H undefined. Seek 
> test didn't run though, but it's not because of these patches, and 
> I'll look into what triggers the error as a separate issue.
>
> Ramiro Polla

-------------- next part --------------
A non-text attachment was scrubbed...
Name: bswap.h.reorder_2.diff
Type: text/x-patch
Size: 3072 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070424/9081aa85/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bswap.h.returnx_2.diff
Type: text/x-patch
Size: 564 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070424/9081aa85/attachment-0001.bin>



More information about the ffmpeg-devel mailing list