[Ffmpeg-devel] [PATCH] utils.c: add vga and qvga name support for resolution

[Ivo]

On Friday 20 April 2007 17:47, Benoit Fouet wrote:
> Ivo wrote:
> > To summarise what should be added IMHO:
> >
> > * xyzga modes
> > * hd modes (hd720, hd1080 and a mode for 1440x1080)
> >
> > Modes that should not be added because of what we discussed earlier:
> > * mobile devices
> > * digital cinema and film scanners
>
> this leads us to something like attached
> does it sound ok to you ?
> and if someone else has something to say... :)
> (hope i didn't mess it up)

> Index: libavformat/utils.c
> ===================================================================
> --- libavformat/utils.c (revision 8761)
> +++ libavformat/utils.c (working copy)
> @@ -2470,6 +2470,31 @@
[..stuff that is ok..]
> +    { "hd480",     852, 480,     0,    0 },
> +    { "hd720",    1280, 720,     0,    0 },
> +    { "hd1080",   1920,1080,     0,    0 },
> +    { "hdv1080",  1440,1080,     0,    0 },

hd480 can be dropped imho.

Maybe we could do:

{ "hd720",	1280, 720,	0,	0	},
{ "hd720p24",	1280, 720,	24000,	1001	},
{ "hd720p25",	1280, 720,	25,	1	},
{ "hd720p30",	1280, 720,	30000,	1001	},
{ "hd720p50",	1280, 720,	50,	1	},
{ "hd720p60",	1280, 720,	60000,	1001	},

and similar for hd1080p{24,25,30,50,60} and hd1080i{25,30}. Or maybe it's 
overkill. I don't know. I think it might be handy, especially if there were 
one command line option to handle both size and rate at once.

--Ivo