[Ffmpeg-devel] Changing "-vstats" option behaviour

[Stefano Sabatini]

On date Friday 2007-04-20 12:36:34 +0200, Benoit Fouet encoded:
> Hi,
> 
> Stefano Sabatini wrote:
> > Index: ffmpeg.c
> > ===================================================================
> > --- ffmpeg.c	(revision 8759)
> > +++ ffmpeg.c	(working copy)
> > @@ -3806,6 +3817,11 @@
> >  
> >      av_free(intra_matrix);
> >      av_free(inter_matrix);
> > +
> > +    if (vstats_filename) {
> > +        fclose(fvstats);
> > +        av_free(vstats_filename);
> > +    }
> >   
> how about:
> if (fvstats)
>     fclose(fvstats);
> av_free(vstats_filename);

I prefer the former for a... psychology reason, enclosing it in a
block make more apparent the correlation between the fvstats and
vstats_filename object...  but isn't really important, so I let the
choice to the maintainers.

Cheers 
-- 
Stefano Sabatini
Linux user number 337176 (see http://counter.li.org)