[Ffmpeg-devel] Changing "-vstats" option behaviour

Michael Niedermayer michaelni
Tue Apr 17 14:34:55 CEST 2007


Hi

On Tue, Apr 17, 2007 at 11:41:57AM +0200, Stefano Sabatini wrote:
[...]
> > I don't really see naming of files based on the current time important
> > enough to warrant this.  If the user wants it, he can format the filename
> > himself using the date command (naturally a female user could do the same,
> > but I can't be bothered to think up a PC synonym for every pronoun).
> > 
> 
> It was to retain backward compatibility (but I also don't regard this
> feature so much important). In each case if someone regards it useful
> I can try to code that feature.
> 
> In attachment there is the svn diff.
> 
> I changed the -vstats option name to -vstats_file, that seems clearer
> and, being different from the previous option name, should also get
> the change more apparent to the user that was used to the previous
> behaviour.
> 
> I also changed the name of the function do_video_stats to do_vstats,
> which seems to me more consistent with the rest of the code.

renamings are cosmetic changes and MUST be seperate from functional changes

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070417/a897aed4/attachment.pgp>



More information about the ffmpeg-devel mailing list