[Ffmpeg-devel] [PATCH] remove drop timecode flag

[Baptiste Coudurier]

Rich Felker wrote:
> On Sun, Apr 15, 2007 at 06:05:21PM +0200, Baptiste Coudurier wrote:
>>> either way theres no reason why ffmpeg should behave like that so the
>>> consequences claimed by the text dont apply ...
>> Why removing the POSSIBILITY to behave like that if the user wants to?
>> That justifies a fork.
> 
> There are all kinds of idiotic things that stupid users might want to
> do, making slightly or even seriously nonsensical files just because
> some crappy legacy implementation writes files that way. Should we
> include support for every possible nonsensical thing? There are
> probably also encoders which generate P frames but with all the
> macroblocks being I blocks; should ffmpeg have a "feature" to do
> something stupid like that too? Of course not!

Drop frame timecode system is useful. I use it, NTSC Broadcasters use
it. SMPTE/ISO/EBU have recommendations about its use. That flag is
specified in MPEG2 standard. Now you are free to not offer that
possibility, it's a matter of personal interest.

> If there's a correct sane way to do things (i.e. specifying the
> correct framerate for your content rather than an incorrect framerate
> plus jerky timestamp jumps)

30000/1001 framerate is correct, correct timecode is defined by
EBU/SMPTE and ffmpeg does it correctly atm.

> then ffmpeg should only generate the
> correct way and not support generating the incorrect one. Of course it
> should be able to handle files from foreign sources that were
> generated in the incorrect way, but it doesn't have to make more bad
> files!

Those files are correct.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312