[Ffmpeg-devel] [PATCH] mjpeg cleanup and again interlaced fix

[Baptiste Coudurier]

Michael Niedermayer wrote:
> Hi
> 
> On Wed, Apr 11, 2007 at 02:17:14PM +0200, Baptiste Coudurier wrote:
>> Hi
>>
>> 3 patches:
>>
>> - remove useless MpegEncContext.
> 
> passed regressions, applied

Thanks.

>> - fix odd field height decoding.
> 
> while ive already said this is ok, i must retract this approval, ive made
> a misstake the patch is totally broken and introduces a exploitable buffer
> overflow, and a fairly obvious one
> using the container height for the allocated image instead of 2*height
> and then decoding a image with the codec height into it of course cannot
> work as theres no guarantee that container height >= 2* codec height
> this also isnt checked anywhere

Ok.

> nice reason to fork, anyone still curious why i reject patches i dont
> fully understand?

Being sarcastic won't lead you to anything, however mentioning what you
just did was constructive, and was clearly non aggressive, thank you.

Now that's not the only reason to fork, and I think I already gave some
good reasons.

Im happy that you fixed bugs, and proved me wrong about the time
counter. I think Im not narrow minded and Im always open for discussion.

Im also thinking that all those flame wars could be avoided and
constructive discussions can really have benefit to both sides.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312