[Ffmpeg-devel] [PATCH] DV timecode

Roman Shaposhnik rvs
Sun Apr 15 01:36:01 CEST 2007


Hi Baptiste,

first of all -- your dv_timecode.patch looks fine to me. But since
it is just 1/3 of an entire patch I'd expect somebody else to commit
the entire thing since it touches areas I don't maintain.

I also do have a question for all ffmpeg developers out here: I don't
quite get why ff_drop_frame_timecode_adjust() works. I see that it
came from  mpeg12.c and I also suspect it is somehow right, but it looks
like a weird way to do LTC timecode. Can somebody please point me
at any docs explaining it?

Thanks,
Roman.

On Wed, 2007-04-11 at 14:29 +0200, Baptiste Coudurier wrote:
> Hi
> 
> 3 patches:
> 
> - add timecode.h to avoid code duplication for drop frame timecode
> adjustment
> - use new lavc timecode api to set timecode in DV. Regression tests
> change because now default behaviour is non drop frame timecode, you can
> still activate it by using -flags2 +drop_frame_timecode
> - timecode helper function for ffmpeg to set timecode.
> 
> Maybe moving brktimegm to lavu and using it is better ?
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel





More information about the ffmpeg-devel mailing list