[Ffmpeg-devel] Re: [PATCH] fix ffmpeg is killed for some img convert

[Michel Bardiaux]

Michael Niedermayer wrote:
> Hi
> 
> On Thu, Apr 12, 2007 at 02:39:12PM +0200, Michel Bardiaux wrote:
>> Michael Niedermayer wrote:
>>> Hi
>>>
>>> On Thu, Apr 12, 2007 at 05:52:45PM +0800, Limin Wang wrote:
>>>> Hi,
>>>>
>>>>> Hi,
>>>>>
>>>>> Update the patch to fix the dead loop recursive function issue, I have 
>>>>> pass
>>>>> simple test for these be killed image conversion and "make test", please
>>>>> review it.
>>>> Any comments? The bug can be reproduced by yuv420p -> bgr32 etc.
>>> well, the old imgconvert/resample code is deprecated and unmaintained
>> img_convert is needed if you want LGPL. So you cant declare it 
>> deprecated and unmaintained. 
> 
> last time i checked you where not my employer so you cant decide what i 
> maintain and what i do not maintain

Now dont blow a fuse... Of course you are perfectly free to chose what 
you, personnally, maintain or not. I objected to the declaration that 
imgconvert would not be maintained by anybody (meaning any patch to it 
would be rejected summarily) and would go away anyway (and would nag 
users with tons of compilation warnings).

> also i dont care about LGPL, 

Your choice, but do you realize the trouble such statements cause to 
people who use ffmpeg in non-GPL projects? When my boss worries about 
the risk associated with using ffmpeg instead of proprietary codecs, I 
cant honestly tell him that there is no risk, because there *are*.

> thouse who do can maintain the code
> or work on getting swscale under LGPL, 

I'm interested, but I would rather not read the whole code, so as to be 
able to claim in good faith a 'white room' completion of the LGPL 
implementation. What is needed for that is a set of specs for the 
functions that remain to write. But there does not seem to be an 
official maintainer for the swscale API in lavc.

> which was almost done when walken
> claimed rights on the yuv2rgb reimplementation and scared the author of
> the code away by that ...
> 
> 
>> In avcodec.h the 'attribute deprecated' for 
>> img_convert should at least be under #ifndef CONFIG_SWSCALER
> 
> NO, RTFS!
> the img_convert code can be used over the swscale API if swscale is
> disabled, the old img_convert API WILL be removed with the next version
> bump
> 
We have sws_scale in imgresample.c calling img_convert, which is in 
another source. As I read avcodec.h, at the bump the prototype for 
img_convert needed by sws_scale will simply become missing. That cant be 
right...

Greetings,
-- 
Michel Bardiaux
R&D Director
T +32 [0] 2 790 29 41
F +32 [0] 2 790 29 02
E mailto:mbardiaux at mediaxim.be

Mediaxim NV/SA
Vorstlaan 191 Boulevard du Souverain
Brussel 1160 Bruxelles
http://www.mediaxim.com/