[Ffmpeg-devel] [PATCH] ATRAC3 decoder

[Benjamin Larsson]

Michael Niedermayer wrote:
> Hi
>
> On Wed, Apr 11, 2007 at 06:34:10PM +0200, Benjamin Larsson wrote:
> [...]
>   
>>>  
>>>       
>>>>        if (selector != 1) {
>>>>            for (cnt = 0; cnt < numCodes; cnt++) {
>>>>                huffSymb = get_vlc2(gb, 
>>>>                spectral_coeff_tab[selector-1].table, 
>>>>                spectral_coeff_tab[selector-1].bits, 3);
>>>>                huffSymb += 1;
>>>>                code = pTable[huffSymb >> 1];
>>>>                if (huffSymb & 1)
>>>>                    code = -code;
>>>>                mantissas[cnt] = code;
>>>>            }
>>>>    
>>>>         
>>> whats the sense in this decTables[] based remapping? why isnt the
>>> spectral_coeff_tab in the proper order?
>>>
>>>  
>>>       
>> No idea, ask Sony.
>>     
>
> is it your code or sonys? if its yours you should be able to explain
> it if not, you should NOT submit it here ...
>
> [...]
>   

Ok, I think you are right those tables aren't needed. I'll sort it out
and resubmit the patch.


MvH
Benjamin Larsson