[Ffmpeg-devel] [PATCH] DVR-MS probe audio format - was DVR-MS bug (MP2 decoding)

John Donaghy johnfdonaghy
Wed Apr 11 22:09:13 CEST 2007


> Hi
>
> On Wed, Apr 11, 2007 at 12:21:56PM -0500, John Donaghy wrote:
> > >
> > >looks good assuming it passes regression tests
> > >
> >
> > As discussed before, the lavf demuxer in libmpdemux will break when
> > this patch is applied. This is because the codec_tag that is read from
> > the dvr-ms file's audio stream header is not reliable. ffmpeg doesnt
> > have a problem with this as long as the codec_id has been set
> > correctly but the lavf demuxer currently needs the codec_tag to either
> > be correct, or else set to '0'.
> >
> > So, if I change the asf.c code that reads the stream header to the
> > following it works in both ffmpeg and maplayer:
> >
> > get_wav_header(pb, st->codec, type_specific_size);
> > if (is_dvr_ms_audio) {
> >    // codec_id is unreliable in dvr_ms files
> >    // set it later by probing stream
> >    st->codec->codec_id = CODEC_ID_NONE;
> >    st->codec->codec_tag = 0;                         // proposed new code
> > }
> >
> > Do you want me to resubmit with this change?
>
> ok
>

Here it is.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lavf_asf_ac3.diff
Type: text/x-patch
Size: 4822 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070411/6e17ba2b/attachment.bin>



More information about the ffmpeg-devel mailing list