[Ffmpeg-devel] Re: Third Try: Set bit_rate for asf format

[Zuxy Meng]

Hi Michael,

2007/4/2, Zuxy Meng <zuxy.meng at gmail.com>:
> Hi,
>
> 2007/3/31, Zuxy Meng <zuxy.meng at gmail.com>:
> > Hi,
> >
> > 2007/3/30, Zuxy Meng <zuxy.meng at gmail.com>:
> > > Hi,
> > >
> > > 2007/3/30, Michael Niedermayer <michaelni at gmx.at>:
> > > > Hi
> > > >
> > > > still i have a bad feeling with setting it just for video knowing it
> > > > breakes audio if it would be set there too ...
> > >
> > > Me too. I'll dig into wma.c this weekend.
> > >
> > > > somehow this isnt a clean solution at all
> >
> > The reason is that for audio streams, there will be a wave header
> > defined at the asf container level, and get_wav_header will set
> > bit_rate as 8*nAvgBytesPerSec. So unlike video streams, we don't need
> > to look for the optional extended stream property object for bitrate.
> >
> > And something more about the fulltest: asf files used/generated in
> > fulltest don't contain extended stream property objects so bitrate[i]
> > == 0, and the subsequent assignment will effectively overwrite what
> > has been found in get_wav_header. This is absolutely my fault; I
> > forgot that such objects are optional, not mandatory.
>
> Please take a look at this patch; hopefully this is cleaner. And it
> passes fulltest, too.

Would u take a look at this? Thanks!
-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6