[Ffmpeg-devel] [PATCH] make pnm.c output gray16 images in machine endianness

[Ivo]

On Saturday 07 April 2007 22:04, Michael Niedermayer wrote:
> Hi
>
> On Sat, Apr 07, 2007 at 09:45:22PM +0200, Ivo wrote:
> > Hi,
> >
> > I thought it'd be best split up the changes to pnm.c and also not bury
> > it in a thread about bit depth support. So, here's a patch that will
> > make the pnm decoder output gray16 images in machine endianness instead
> > of the file's big-endian order.
>
> hmm, i dont like this, the conversation could as well be done outside the
> codec where it belongs
> its not like the format isnt supported or that we would have to
> copy all the data anyway (your code rather adds a additional pass over
> the image ...)

Yes. I think I misunderstood you when you said (in the other thread about 
bit depths):

> 16bit formats should be in native endian internally (for obvious reasons)

I thought you meant the decoder should output native endian data instead of 
always big-endian as it does now.

Perhaps you meant it should output native endian data only when it has to do 
another pass over the data anyway when it scales the bit depth up to 
16-bits? I am not sure what you meant :)

--Ivo