[Ffmpeg-devel] Re: Bethsoft VID demuxer and decoder

[Nicholas T]

I disagree with pt 2. Other things changed, yes it is nitpicking. I
hope you understand that I am new to ffmpeg's code, so I wrote now
obvious comments so I could remember what library functions were
doing.

Nicholas

On 4/7/07, Diego Biurrun <diego at biurrun.de> wrote:
> On Sat, Apr 07, 2007 at 07:23:13AM -0700, Nicholas T wrote:
> >
> > --- libavcodec/bethsoftvideo.c        (revision 0)
> > +++ libavcodec/bethsoftvideo.c        (revision 0)
> > @@ -0,0 +1,143 @@
> > +/*
> > + * Nicholas Tung, Google Summer of Code application
>
> This is irrelevant, remove it.
>
> > + * Helpful references: aasc.c, http://wiki.multimedia.cx/index.php?title=FFmpeg_codec_howto
>
> same here
>
> > +    /* formats in libavutil/avutil.h
> > +       pal8 has some information which tells this that the palette is
> > +       vid->frame.data[1], and an image would be in vid->frame.data[0] */
>
> nit: PAL8
>
> I cannot really understand this comment, what is "this"?
>
> Diego
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>


-- 
http://ntung.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bethsoft.diff
Type: text/x-patch
Size: 18053 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070407/64af7762/attachment.bin>