[Ffmpeg-devel] [patch] code-cleanup: make some function static

Diego Biurrun diego
Fri Apr 6 11:39:19 CEST 2007


On Wed, Apr 04, 2007 at 04:22:40PM +0300, Kostya wrote:
> On Wed, Apr 04, 2007 at 01:35:30PM +0200, Stefan Huehner wrote:
> > 
> > attached makes some functions static which aren't used outside their
> > delcaring source file and have no prototype in a header file.
>  
> Applied my part (vc1.c)

Why don't you apply the whole patch instead of ripping out the hunk for
a single file?  It seems you consider it correct, Mans said it was
correct.  Plus, it's *more* work to rip out a single piece of it than to
apply it as a whole...

Diego




More information about the ffmpeg-devel mailing list