[Ffmpeg-devel] Re: WMA decoder improvement

[Baptiste Coudurier]

Hi

Patrice Bensoussan wrote:
> [...]
> 
> This patch completely breaks the decoding of sample files I have.
> Moreover it generate a lot of warnings at runtime related to double
> free() calls.
> See ffmpeg output below:
> 
> [patriceb at patrice-bensoussans-ibook-g4 ~/tmp/WMA/ffmpeg/ppc]$ ./ffmpeg
> -i ~/tmp/WMA/songs/blacksmith.wma ~/Desktop/test.mp3
> FFmpeg version SVN-r8627, Copyright (c) 2000-2007 Fabrice Bellard, et al.
>   configuration: --cc=gcc-3.3 --enable-pthreads --disable-network
> --disable-vhook --enable-small --enable-libmp3lame --enable-libfaac
> --disable-decoder=cook --extra-ldflags=-L/Users/patriceb/tmp/WMA/opt/lib
> --extra-cflags=-I/Users/patriceb/tmp/WMA/opt/include --enable-gpl
> --enable-x264 --enable-liba52 --enable-libfaad
>   libavutil version: 49.4.0
>   libavcodec version: 51.40.2
>   libavformat version: 51.11.0
>   built on Apr  5 2007 21:33:38, gcc: 3.3 20030304 (Apple Computer, Inc.
> build 1819)
> Input #0, asf, from '/Users/patriceb/tmp/WMA/songs/blacksmith.wma':
>   Duration: 00:00:34.2, start: 2.600000, bitrate: 164 kb/s
>   Stream #0.0: Audio: wmav2, 44100 Hz, stereo, 160 kb/s
> Output #0, mp3, to '/Users/patriceb/Desktop/test.mp3':
>   Stream #0.0: Audio: mp3, 44100 Hz, stereo, 64 kb/s
> Stream mapping:
>   Stream #0.0 -> #0.0
> Press [q] to stop encoding
> size=     266kB time=34.1 bitrate=  64.0kbits/s
> video:0kB audio:266kB global headers:0kB muxing overhead 0.000000%
> ffmpeg(23258) malloc: ***  Deallocation of a pointer not malloced:
> 0x4380d54d; This could be a double free(), or free() called with the
> middle of an allocated block; Try setting environment variable
> MallocHelp to see tools to help debug
> ffmpeg(23258) malloc: ***  Deallocation of a pointer not malloced:
> 0x437d337d; This could be a double free(), or free() called with the
> middle of an allocated block; Try setting environment variable
> MallocHelp to see tools to help debug
>
> [...]
> 
> Patch should be reverted IMHO until it gets fixed. Converted mp3 file is
> not audible.
> 

Can you please upload a non working sample following
http://ffmpeg.mplayerhq.hu/bugreports.html ? Thanks.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312