[Ffmpeg-devel] Re: Bethsoft VID demuxer and decoder

[Diego Biurrun]

On Wed, Apr 04, 2007 at 11:39:25AM -0700, Nicholas T wrote:
> 
> --- libavcodec/bethsoftvideo.c	(revision 0)
> +++ libavcodec/bethsoftvideo.c	(revision 0)
> @@ -0,0 +1,181 @@
> +/*
> + * Bethesda VID decoder
> + * Copyright (C) 2007 the ffmpeg project
> + * Nicholas Tung, Google Summer of Code application

The name is FFmpeg (notice the capitals).  However, the FFmpeg project
is not a legal entity.  Put your name there instead, it's what we do
commonly around here.

> --- libavcodec/avcodec.h	(revision 8603)
> +++ libavcodec/avcodec.h	(working copy)
> @@ -2363,6 +2364,7 @@
>  extern AVCodec xl_decoder;
>  extern AVCodec zlib_decoder;
>  extern AVCodec zmbv_decoder;
> +extern AVCodec bethsoftvid_decoder;

Please respect alphabetical order.

> --- libavformat/bethsoftvid.c	(revision 0)
> +++ libavformat/bethsoftvid.c	(revision 0)
> @@ -0,0 +1,251 @@
> +/*
> + * Bethsoft VID format Demuxer
> + * Copyright (c) 2003 The ffmpeg Project

see above

> --- libavformat/allformats.h	(revision 8603)
> +++ libavformat/allformats.h	(working copy)
> @@ -168,6 +168,7 @@
>  extern AVInputFormat tiertexseq_demuxer;
>  extern AVInputFormat x11_grab_device_demuxer;
> +extern AVInputFormat bethsoftvid_demuxer;
>  extern AVInputFormat thp_demuxer;

see above

Also, this file has been changed in the meantime, your patch will not
apply cleanly.

Diego