[Ffmpeg-devel] [PATCH] TIFF encoder (Google SoC qualification task)

[Michael Niedermayer]

Hi

On Tue, Apr 03, 2007 at 01:25:25AM +0200, Kamil Nowosad wrote:
[...]
> > > > > Index: libavcodec/tiffenc.c
> > > > > ===================================================================
> > > > > --- libavcodec/tiffenc.c	(wersja 0)
> > > > > +++ libavcodec/tiffenc.c	(wersja 0)
> > > > [...]
> > > > 
> > > > > +    uint16_t *color_map;
> > > > 
> > > > this could as well be a local array
> > > 
> > > Shouldn't I rather allocate the memory for that in tiff_init and free
> > > in tiff_end ? I forgot about moving it there...
> > 
> > why? its not needed after encoding the current frame or?
> 
> Although the solution with local array is somewhat simpler, I think that
> allocating the memory for palette once in tiff_init and freeing in
> tiff_end is somewhat more elegant than reserving it each time (even if
> it the palette is not used at all) on the stack.

well, if you prefer it that way then ill accpet it ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070403/133de6f8/attachment.pgp>