[Ffmpeg-devel] [PATCH] C93 demuxer and decoder (GSoC qualification task)

[Michael Niedermayer]

Hi

On Sun, Apr 01, 2007 at 10:16:22PM +0100, M?ns Rullg?rd wrote:
[...]
> > +    newpic->reference = 1;
> > +    if (buf[0] & 0x02) { /* first frame */
> 
> #define C93_FIRST_FRAME 2 or something and drop the comment.
> 
> > +        newpic->pict_type = FF_I_TYPE;
> > +        newpic->key_frame = 1;
> > +    } else {
> > +        newpic->pict_type = FF_P_TYPE;
> > +        newpic->key_frame = 0;
> > +    }
> > +
> > +    if ((buf++)[0] & 0x01) { /* contains palette */
> 
> *buf++, and make that 1 a #define too.
[...]
> > +    pkt->data[0] = palettesize ? 0x01 : 0x00;
> 
> pkt->data[0] = !!palettesize;

that contradicts your previous suggestions a little ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070402/443168aa/attachment.pgp>