[Ffmpeg-devel] [PATCH] vorbis.h -> vorbis_data.c

[Oded Shimon]

On Sat, Sep 30, 2006 at 09:30:41PM +0300, Oded Shimon wrote:
> On Sat, Sep 30, 2006 at 09:27:50PM +0300, Oded Shimon wrote:
> > On Sat, Sep 30, 2006 at 07:51:14PM +0200, Michael Niedermayer wrote:
> > > Hi
> > > 
> > > On Sat, Sep 30, 2006 at 07:28:30PM +0300, Oded Shimon wrote:
> > > > On Sat, Sep 30, 2006 at 06:25:24PM +0200, Michael Niedermayer wrote:
> > > > > On Sat, Sep 30, 2006 at 06:27:16PM +0300, Oded Shimon wrote:
> > > > > > made 2 changes as Mans and Denes requested, the structs stay in vorbis.h
> > > > > 
> > > > > looks ok
> > > > 
> > > > This is not the up-to-date patch, <20060930155533.GQ6927 at crate15> is. The 
> > > > structs are moved after all to vorbis.c .
> > > 
> > > iam fine with that too
> > > but then vorbis.h has nothing in common anymore with the old vorbis.h
> > > (except the license header but that doesnt count) or is there something else?
> > 
> > nope, nothing... I was reluctant about changing the license header :)
> > 
> > > if not then the new vorbis.h should be added with svn add not as a
> > > difference to the old vorbis.h
> > > 
> > > one way to actually do this (svn is a pile of shit ...) should be something
> > > like:
> > > 
> > > svn mv vorbis.h vorbis_data.c
> > > change all vorbis.h -> vorbis_data.c references
> > > svn ci
> > > 
> > > apply patch
> > > reverse the #include "vorbis_data.c" mess
> > > svn add vorbis.h
> > > svn ci
> > 
> > is it possible to do 'svn mv' and 'svn add' in one go?
> > 
> > svn mv vorbis.h vorbis_data.c
> > svn add vorbis.h
> > 
> > I'll check on a test repo...
> 
> Works fine, I'll use this.
> 
> BTW, should there evn be a copyright header in vorbis_data.c ?..

Committed. I put my own name in vorbis.h .. I hope noone minds..

- ods15