[Ffmpeg-devel] [PATCH] AVISynth support for some MS DIB formats

Michael Niedermayer michaelni
Fri Sep 29 20:08:49 CEST 2006


Hi

On Thu, Sep 28, 2006 at 02:17:51PM +0200, Steve Lhomme wrote:
> Steve Lhomme wrote:
> >Michael Niedermayer wrote:
> >>>Index: avisynth.c
> >>>===================================================================
> >>>--- avisynth.c    (revision 6352)
> >>>+++ avisynth.c    (working copy)
> >>>@@ -95,6 +95,7 @@
> >>>                   stream->chunck_size = stream->chunck_samples * 
> >>>wvfmt.nChannels * wvfmt.wBitsPerSample / 8;
> >>> 
> >>>                   st->codec->codec_id = 
> >>>wav_codec_get_id(wvfmt.wFormatTag, st->codec->bits_per_sample);
> >>>+                  st->codec->codec_tag = stream->info.fccHandler;
> >>
> >>this looks wrong stream->info.fccHandler should be 
> >>st->codec->stream_codec_tag
> >>and wvfmt.wFormatTag should be codec_tag
> >>
> >>
> >>>                 }
> >>>               else if (stream->info.fccType == streamtypeVIDEO)
> >>>                 {
> >>>@@ -117,7 +118,27 @@
> >>> 
> >>>                   st->codec->bits_per_sample = 
> >>>stream->info.dwSampleSize * 8;
> >>>                   st->codec->bit_rate = 
> >>>(uint64_t)stream->info.dwSampleSize * (uint64_t)stream->info.dwRate * 
> >>>8 / (uint64_t)stream->info.dwScale;
> >>>-                  st->codec->codec_id = codec_get_id(codec_bmp_tags, 
> >>>stream->info.fccHandler);
> >>
> >>same here, it should be imgfmt.bmiHeader.biCompression not 
> >>stream->info.fccHandler id also guess thats why the code didnt work 
> >>though
> >>iam just guessing, what happens if you change these?
> >
> >I'll give this a try. I'll keep you updated.
> 
> OK, it's better (more general). Here is the patch.

looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is




More information about the ffmpeg-devel mailing list