[Ffmpeg-devel] Re: [PATCH] Delphine Software .CIN files support

[Gregory Montoir]

Hi,

Michael Niedermayer wrote:
> Hi
> 
> [...]
> 
> * furthermore please check that no writes to unallocated memory can happen
> * use the bitstream reader if it simplifies the code
> * use get_le*() instead of get_buffer() + LE_*() unless the code
>   is speed critical or its otherwise needed or cleaner to use LE_*()
> * set the timebases correctly (if theres no real timebase/timestamps then
>   1/framerate and 1/samplerate are the correct values)
> 
> ill do a real review when you ve fixed these
> 

Updated patch attached.

Regards,
Gregory


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ffmpeg-delphinecin-20060920.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060921/fdffd818/attachment.asc>