[Ffmpeg-devel] [PATCH] Use ff_eval for AVOption parsing

[Panagiotis Issaris]

Hi,

Op woensdag 27 september 2006 00:26, schreef Michael Niedermayer:
> > [...]
> > Should I have put this (in mpegvideo.h):
> >  994 double ff_eval(char *s, double *const_value, const char **const_name,
> >  995                double (**func1)(void *, double), const char **func1_name,
> >  996                double (**func2)(void *, double, double), char **func2_name,
> >  997                void *opaque);
> > 
> > Within this too?
> > #if LIBAVCODEC_VERSION_INT < ((51<<16)+(16<<8)+0)
> > ...
> > #endif
> 
> yes probably
The attached patch makes ratecontrol use ff_eval2().
Regression tests succeed.

 mpegvideo.h   |    6 ++++++
 ratecontrol.c |    8 ++++++--
 2 files changed, 12 insertions(+), 2 deletions(-)

> well actually the whole ff_eval doesnt belong into mpegvideo.h ...
Let me know if you prefer to have ff_eval* in a separate eval.h file.

With friendly regards,
Takis
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20060927T132230-ffmpeg-use_ff_eval2.diff
Type: text/x-diff
Size: 2122 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060927/bdffd281/attachment.diff>