[Ffmpeg-devel] [PATCH] fix get_bits_long with ALT_BITSTREAM_READER_LE

Reimar Döffinger Reimar.Doeffinger
Tue Sep 26 00:19:18 CEST 2006


Hello,
On Tue, Sep 26, 2006 at 12:06:39AM +0200, Michael Niedermayer wrote:
> [...]
> >  // shamelessly copied from shorten.c
> >  static int inline get_le16(GetBitContext *gb)
> >  {
> > -    return bswap_16(get_bits_long(gb, 16));
> > +    return get_bits_long(gb, 16);
> >  }
> 
> id suggest to replace get_le16 by get_bits(16)
> 
> >  static int inline get_le32(GetBitContext *gb)
> >  {
> > -    return bswap_32(get_bits_long(gb, 32));
> > +    return get_bits_long(gb, 32);
> >  }
> 
> id suggest to replace get_le32 by get_bits_long(32)

I would have suggested that in a separate patch since it is somewhat cosmetic,
or do you prefer it to be done in one patch?

Greetings,
Reimar D?ffinger




More information about the ffmpeg-devel mailing list