[Ffmpeg-devel] [PATCH] Ratecontrol does not check for failure of ff_eval

[Panagiotis Issaris]

Hi,

Op zondag 24 september 2006 14:57, schreef Michael Niedermayer:
>[...]
> > I'd think propagating the error would be the best thing to do, so the
> > calling application can handle the error as it pleases. Would a patch
> > propagating the NAN upwards be okay?
> 
> yes (or -1 or something like that)

Was the -1 suggestion just a preference or because of some idea of yours
that NAN might fail somewhere? :)

There reason I'm asking is that I just noticed (after a lot of tracing) that
quality is an int, and ff_rate_estimate_qscale returns a float... Thus, my
NAN is gone :)

    5466 static void estimate_qp(MpegEncContext *s, int dry_run){
    5467     if (!s->fixed_qscale)
    5468         s->current_picture_ptr->quality=
    5469         s->current_picture.quality = ff_rate_estimate_qscale(s, dry_run);
    5470
 
With friendly regards,
Takis