[Ffmpeg-devel] [PATCH] drawtext.c: 06 fix skip underscore

[Gustavo Sverzut Barbieri]

On 9/10/06, Gustavo Sverzut Barbieri <barbieri at gmail.com> wrote:
> On 9/10/06, M?ns Rullg?rd <mru at inprovide.com> wrote:
> > "Gustavo Sverzut Barbieri" <barbieri at gmail.com> writes:
> >
> > > On 9/10/06, M?ns Rullg?rd <mru at inprovide.com> wrote:
> > >> "Gustavo Sverzut Barbieri" <barbieri at gmail.com> writes:
> > >>
> > >> > vhook cmdline argument doesn't like nested spaces, so in order to have
> > >> > spaces in strings used in command line I have to replace underscore
> > >> > with spaces, but only when used from command line, so if someone want
> > >> > to use underscores, one may use a file.
> > >>
> > >> What are "nested spaces"?  Are you sure there's no cleaner solution?
> > >
> > > ./ffmpeg -vhook "./vhook/drawtext.so -ttest_abc"
> > >
> > > works, while
> > >
> > > ./ffmpeg -vhook "./vhook/drawtext.so -t'test abc'"
> > >
> > > doesn't.
> >
> > If you want to fix this, a better approach would be to implement
> > support for quotes.  The wordexp() function could come in handy there.
>
> Okay, so I'll remove this and later fix vhook.
>
> Is this ok now?

any objections?

-- 
Gustavo Sverzut Barbieri
--------------------------------------
Jabber: barbieri at gmail.com
   MSN: barbieri at gmail.com
  ICQ#: 17249123
 Skype: gsbarbieri
Mobile: +55 (81) 9927 0010
 Phone:  +1 (347) 624 6296; 08122692 at sip.stanaphone.com
   GPG: 0xB640E1A2 @ wwwkeys.pgp.net