[Ffmpeg-devel] privatizing FifoBuffer into libavutil -- take II

[Roman Shaposhnick]

Hi

On Wed, Sep 20, 2006 at 11:01:11AM +0200, Michael Niedermayer wrote:
> On Tue, Sep 19, 2006 at 11:32:54PM -0700, Roman Shaposhnik wrote:
> > Here's an updated version with everything mentioned taken into
account.
> >
> > Please let me know if its ok to commit it.
>
> looks ok, 

  good. I'll commit it then.

> except the tabs but you wont be able to commit it with them
> anyway thanksto our pre commit check scripts

  Ah! But I have a very same script purifying my commits before they
go over the wire ;-)

> also it would be interresting to make the various parts of libavutil
> conditional based on configure switches and actual need, for example
> the md5 stuff could be skiped if no format and codec needs it and
> the user doesnt explicitly ask for it either ... of course thats
> off topic and seperate i know ...

  Modularity is high on my list as well. I also would like to explore
the opportunity of actually querying for compiler feature(s) instead of
doing #ifdef __GNUC__ all over the place. But more on that later.

Thanks,
Roman.