[Ffmpeg-devel] [PATCH] [Visibility] Try 2: libpostproc public functions

Michael Niedermayer michaelni
Wed Sep 20 11:28:03 CEST 2006


Hi

On Wed, Sep 20, 2006 at 09:27:50AM +0200, Diego 'Flameeyes' Petten? wrote:
> On Wednesday 20 September 2006 09:18, Diego Biurrun wrote:
> > I still think there has to be a way to do this from configure/config.h
> I'm open to suggestion, but I don't think that using config.h would be a good 
> idea, because it's (correctly) not installed, while the headers where 
> visibility is set are (and the attributes should apply if FFmpeg is being 
> used by a project that has its own -fvisibility too).
> This is also why I didn't go with a HAVE_VISIBILITY defined during configure.

and theres another issue, the headers MUST work even if the compiler used by
the application and the libav differ (like one not supporting visibility)

is there really any visibility attribute needed on the app side of the header?

and a app which sets -fvisibility to something funny cannot expect that every
header used by it will override the silly default
if there is not a way to override this per header on the app side then this
is yet another insanity like the PT_GNU_STACK design

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is




More information about the ffmpeg-devel mailing list