[Ffmpeg-devel] [PATCH] Remove "bufsize" OptionDef option

Rich Felker dalias
Sat Sep 16 21:38:57 CEST 2006


On Sat, Sep 16, 2006 at 09:23:34AM +0200, Panagiotis Issaris wrote:
> Hi,
> 
> On za, 2006-09-16 at 01:11 +0200, Michael Niedermayer wrote:
> >[...]
> > > The attached patch removes the "bufsize" OptionDef option from the
> > > ffmpeg.c file. The equally named "bufsize" AVOption takes over its
> > > function and this occurs transparantly with the exception of the
> > > parameter unit change. Regression tests succeed.
> > > 
> > > So, this is yet another case where the unit of a commandline unit is
> > > changed, this time from from kilobytes to bits. Using the postfix "kB"
> > > eases the situation:
> > > * Before this patch:
> > >     ffmpeg -i src.ext -bufsize 224 dst.ext
> > > * After this patch:
> > >     ffmpeg -i src.ext -bufsize 224kB dst.ext
> > 
> > no this is not the same theres a 1000/1024 difference
> 
> Oops. You are right. Sorry about that. 
> 
> So, it seems we really do need the kiB postfix. I'll have a try at that.

Uhg....

Rich





More information about the ffmpeg-devel mailing list