[Ffmpeg-devel] [PATCH] Add kibi, mibi and gibi support

Panagiotis Issaris takis.issaris
Sat Sep 16 09:56:21 CEST 2006


Hi,

The attached patch adds support for the "ki", "Mi" and "Gi" postfixes to
the AVOption option parsing code. I do know that this in fact is
incorrect, as the official SI standard uses "Ki" instead of "ki" "for
consistency reasons" [1]. 

I was wondering how to solve this? Should I just make the kilo case
insensitive thus allow both 'k' and 'K' for both? Or make all of them
case insensitive? What about 'B' then? I had the initial intention to
have 'B' stand for "byte" and 'b' for "bit" with "" being a shorthand
for 'b'. If case sensitivity would be removed, both "b" and "B" would
stand for "byte" (in the current implementation).

 opt.c |   20 +++++++++++++-------
 1 files changed, 13 insertions(+), 7 deletions(-)

With friendly regards,
Takis

[1] That's atleast what someone once told me... that it was to be
consistent with M and G. Which imho is rubbish, as it makes it
inconsistent with all the rest of the unit system :-(
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20060916T094613-ffmpeg-binary_powers.diff
Type: text/x-patch
Size: 1209 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060916/345599ab/attachment.bin>



More information about the ffmpeg-devel mailing list