[Ffmpeg-devel] [PATCH] Remove "preme" OptionDef option

[Michael Niedermayer]

Hi

On Fri, Sep 15, 2006 at 05:10:00PM +0200, Panagiotis Issaris wrote:
> Hi,
> 
> Op vrijdag 15 september 2006 16:56, schreef Panagiotis Issaris:
> > The attached patch removes the "preme" OptionDef option from the ffmpeg.c 
> > file. Regression tests succeed.
> > 
> >  ffmpeg.c |    9 ---------
> >  1 file changed, 9 deletions(-)
> > 

patch ok, and i think that as long as you dont change behavior (bit vs. kbit
for example) you can (if you want) commit these things straight without 
sending a patch


> 
> To make sure these patches are not altering behavior, I've done some
> additional tests after the standard regression tests.
> 
> I transcoded some sample file to another format, while using the
> modified parameter ("preme" in this case). To make sure that the
> modified parameter had any influence at all, I checked the md5sum
> of the resulting file, while using different values for "preme".
> Then I did the same tests with the unpatched executable and
> verified that the md5sum for different values was the same as
> with the patched executable.
> 
> The reason I was doing so was that a simple "grep preme tests/*"
> or "grep ibias tests/*" didn't give any results, which made
> me assume the impact of using these variables isn't tested.
> 
> Should I try to add such tests to the testsuite?

yes, but please add them to existing tests to avoid slowing things down
unreasonably

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is