[Ffmpeg-devel] vhook/fish.c compilation broken with gcc 2.95

Måns Rullgård mru
Tue Sep 12 12:06:05 CEST 2006


Luca Abeni said:
> [...]
> make[1]: Entering directory `/tmp/ffmpeg/vhook'
> gcc -I.. -I/tmp/ffmpeg -I/tmp/ffmpeg/libavutil -I/tmp/ffmpeg/libavcodec
> -I/tmp/ffmpeg/libavformat -fPIC  -g -Wall -Wno-switch -Wpointer-arith
> -Wredundant-decls -Winline -O3 -DHAVE_AV_CONFIG_H `freetype-config --cflags`
> -c -o fish.o fish.c
> fish.c: In function `Process':
> fish.c:378: parse error before `*'
> fish.c:381: `fname' undeclared (first use in this function)
> fish.c:381: (Each undeclared identifier is reported only once
> fish.c:381: for each function it appears in.)
> fish.c:382: `f' undeclared (first use in this function)
> make[1]: *** [fish.o] Error 1
> make[1]: Leaving directory `/tmp/ffmpeg/vhook'
> make: *** [videohook] Error 2
>
> The attached patch fixes it... Ok to commit?

Is that mixed code and declarations?  Then the declarations should be moved to
start of the block they are in.  Your fix looks like it moves them to an outer
block.

-- 
M?ns Rullg?rd
mru at inprovide.com




More information about the ffmpeg-devel mailing list