[Ffmpeg-devel] privatizing FifoBuffer into libavutil

Måns Rullgård mru
Sun Sep 10 22:36:14 CEST 2006


Roman Shaposhnik <rvs at sun.com> writes:

> On Sun, 2006-09-10 at 12:01 +0100, M?ns Rullg?rd wrote:
>> Roman Shaposhnik <rvs at sun.com> writes:
>> 
>> > Guys,
>> >
>> > attached is a pretty trivial move of FifoBuffer functionality
>> > from libavformat/avformat.h and libavformat/util.c into
>> > libavutil/fifo.[ch]. Please let me know if that's the best
>> > way to privatize FifoBuffer.
>> >
>> > Thanks,
>> > Roman.
>> >
>> > P.S. The only caveat here is an implicit put_buffer declaration
>> > in fifo.c
>> 
>> No implicit declarations, please.  Why don't you #include whatever
>> header file has the declaration?
>
>   I believe the idea is to keep libavutil free from dependencies 
> on any other libav*.

Sure, but then you can't use put_buffer().  Leaving it undeclared
doesn't change this.

-- 
M?ns Rullg?rd
mru at inprovide.com




More information about the ffmpeg-devel mailing list