[Ffmpeg-devel] [PATCH] allow ffmpeg to read mp3s beginning with partial frames

[Victor Voros]

 <<differences>> Comments below

-----Original Message-----
From: ffmpeg-devel-bounces at mplayerhq.hu
[mailto:ffmpeg-devel-bounces at mplayerhq.hu] On Behalf Of Michael
Niedermayer
Sent: 07 September 2006 00:35
To: FFMpeg development discussions and patches
Subject: Re: [Ffmpeg-devel] [PATCH] allow ffmpeg to read mp3s beginning
with partial frames

Hi

On Thu, Sep 07, 2006 at 12:05:04AM +0100, Victor Voros wrote:
> Hi this is the first time im posting here  so apologies if format is
> wrong etc.
> 
> Some mp3s I have begin with partial frames before the first
> Sync frame. WMP and ITunes handle them OK but SVN FFmpeg does not. Can
> send several examples of mp3 files that are like this.

yes, a sample which shows the problem would be needed

3 samples at
ftp://upload.mplayerhq.hu/MPlayer/incoming/mp3frameprob/partial_frame_mp
3s.rar



> 
> Attached is a patch to libavformat\mp3.c which addresses this in diff
-u
> format from head (6180)
> 
> Simply scans the file looking for a sync frame and starts there if
> found.

rejected, this does not belong in libavformat, demuxers should output
whats in the file, not do codec specific parsing and discarding of stuff
such code should be in the parser or decoder

mp3.c as I see it serves 2 purposes, 1) to determine whether the file is
in fact an mp3 file (mp3_Read_probe) and 2) to prime the file so its
pointing at the start of the first frame, (currently skipping a possible
id3 tag) ready for the codec to do its work(mp3_read_header). The file
already has code to search for a valid mpeg frame sync, the change
expands on this by not assuming the frame sync is at the very start of
the file. No extra codec 'knowledge' has been added to this file.

In any case, mp3_read_probe is the routine rejecting the said files. One
way or another this has to change to accommodate the files. 

furthermore, the line endings in your patch look bad

try attached. 

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel at mplayerhq.hu
http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel


------------------------------------------------------------------------------
This e-mail and its contents are intended for the use of the addressee(s) and may be confidential/privileged. No-one else may review, copy, disclose or otherwise use it or its contents. If you receive this e-mail in error, please contact the originator and delete it as soon as possible.
Benfield Limited is authorised by the Financial Services Authority under the reference number 311884. Registered in England no 1170753. Registered office 55 Bishopsgate.

Please refer to Benfield Limited's terms and conditions (www.benfieldgroup.com/terms) for a description of our services, duties and points of contact. Please review these terms and conditions at inception and renewal of all reinsurance and insurance contracts.  

Please note that our terms and conditions and interests in other companies may change over time and these changes will be reflected on the Benfield Limited website. The latest version of our terms and conditions supersedes all previous versions.
==============================================================================
-------------- next part --------------
A non-text attachment was scrubbed...
Name: differences
Type: application/octet-stream
Size: 3351 bytes
Desc: differences
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060907/aa6f0f00/attachment.obj>