[Ffmpeg-devel] [PATCH] rewrite vhook/drawtext.c

[Michael Niedermayer]

Hi

On Tue, Sep 05, 2006 at 11:25:59PM -0300, Gustavo Sverzut Barbieri wrote:
> Ok, based on comments, here is the second try, changes:
> 
> - err() and warn() -> av_log()

no its stil full of err, fprintf, fputc and so on


> - makefile: use vhook specific LDFLAGS by appending library name with
> $(LDFLAGS_$@) and defining LDFLAGS_drawtext.so. I'm not sure if this
> works with every build system, please check.

could you summarize the difference between the old and rewritten drawtext.c

also if the files have nothing in common then replacing the old by the new
will not be accepted, rather add the new as drawtext2.c and disable the
old but not remove it, if then after a few month there are no complaints
then the old could be removed

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is