[Ffmpeg-devel] [PATCH] Split DV demuxer/muxer

Panagiotis Issaris takis.issaris
Tue Sep 5 23:15:02 CEST 2006


Hi,

On wo, 2006-09-06 at 00:40 +0200, Luca Barbato wrote:
> >> [a bloody mess to spit dv in dv{enc,dec}]
> > What do you consider a "bloody mess"? The split, or the
> > commands needed to preserve history in SVN?
> 
> the svn part
Agreed. But apparently, it can be done shorter and cleaner as
pointed out by both Reimar D?ffinger and Diego Biurrun.

That said, I am not very familiar with SVN (although I do use it), as I
prefer GIT.

> > And, in fact, imho it is cleaner to have it split. It was quite
> > easy even, as there seemed to be no functions or structs being
> > shared between the muxer and demuxer.
> 
> So all it is having 4 lines added to the dv.c or about 6 commands - 8
> commands and changes across 2 files, I'm pretty uncertain about what's
> quicker and saner in the long run...
As pointed out by more experienced SVN users, it is in fact only three
commands extra when compared to applying a patch and commiting to SVN. 
And furthermore, there would be more patches, as currently
--disable-demuxer=dv/--disable-muxer=dv does not disable the compilation
of the demuxer/muxer.

With friendly regards,
Takis





More information about the ffmpeg-devel mailing list