[Ffmpeg-devel] [PATCH] rewrite vhook/drawtext.c

Diego Biurrun diego
Tue Sep 5 14:15:01 CEST 2006


On Mon, Sep 04, 2006 at 09:26:14PM -0300, Gustavo Sverzut Barbieri wrote:
> On 9/4/06, Diego Biurrun <diego at biurrun.de> wrote:
> >On Mon, Sep 04, 2006 at 10:19:39AM -0300, Gustavo Sverzut Barbieri wrote:
> >>
> >> Comments are always welcome!
> >>
> >> --- Makefile  (revision 6159)
> >> +++ Makefile  (working copy)
> >> @@ -15,12 +15,18 @@
> >>
> >>  ifeq ($(HAVE_FREETYPE2),yes)
> >>      HOOKS += drawtext$(SLIBSUF)
> >> -    CFLAGS += `freetype-config --cflags`
> >> -    LDFLAGS += `freetype-config --libs`
> >> +
> >> +drawtext.o: drawtext.c
> >> +     $(CC) $(CFLAGS) -Wall -Werror -g -c -o $@ $< $(VHOOKCFLAGS) 
> >`freetype-config --cflags`
> >
> >Leave this like it was before, this is redundant.
> 
> So, should I add $(freetype-config --cflags) and $(freetype-config
> --libs) to flags so every hook will like to it?

freetype-config --cflags only adds another include directory, this is
harmless.

Diego




More information about the ffmpeg-devel mailing list