[Ffmpeg-devel] [PATCH] BMP encoder

[Michael Niedermayer]

Hi

On Tue, Oct 31, 2006 at 02:33:24PM +0100, Michel Bardiaux wrote:
> Michael Niedermayer wrote:
> >Hi
> >
> >you are quicker with sending patches then iam with thinking about how to
> >optimally solve the issues ...
> >
> >lets see we have 
> >LD*/ST* from dsputil.h which read and write unaligned native endian
> >LE_*/BE_* from avcodec.h which read unaligned little and big endian 
> >bytestream_get_* in bytestream which read unaligned little endian and
> >increase a pointer
> >
> >IMHO bytestream.h should only contain functions which increase a pointer
> >similar to what is currently in there
> 
> OK, no touchy bytestream.h. But I dont understand why you passed the 
> introduction (and use in snow) of 2 different APIs for essentially the 
> same thing.

iam not sure what you are talking about but whatever it is iam just a
human and so i am not perfect which means my code and code i review
will never be entirely bugfree and could due to oversight or stupidity
contain code duplication


> 
> >
> >macros to read and write little,big and native endian should be IMHO in a
> >seperate file, also LE*/BE*/LD*/ST* should be moved into that 
> 
> Something not clear to me here: LE*/BE*/LD*/ST* to, say, bytebuffer.h 
> (OK?),

byteaccess.h, byteutil.h or byteio.h hmm no i like neither :(
so if noone else has a better suggestion then iam fine with bytebuffer.h
we can rename it later ...


> that's clear. But apart from these, which "macros to read and 
> write little,big and native endian"?

none, there just is the LE/BE/LD/ST stuff, sorry if ive been unclear


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is