[Ffmpeg-devel] [PATCH] BMP encoder

[Måns Rullgård]

Michel Bardiaux said:
> Michael Niedermayer wrote:
>> Hi
>>
>> On Tue, Oct 31, 2006 at 02:27:10PM +0100, Michel Bardiaux wrote:
>>> Michael Niedermayer wrote:
>>>> Hi
>>>>
>>>> On Mon, Oct 30, 2006 at 06:50:35PM +0100, Michel Bardiaux wrote:
>>>>> If not, then why the 'else not GNUC clause?
>>>> because we do support a few other compilers ...
>>> But if dsputil.h is NOT supposed to be exported, then it has only to
>>> support gcc.
>>
>> no because we do support other compilers, gcc is not the only c compiler
>> on the planet, we do not support c++ compilers but thats a differnt matter
>
> Mmm, yes, gcc has been the only more-or-less C9X compiler for so long
> that one tends to forget there may be others (BTW do you know one?)

For x86 there are Intel's ICC and Sun's compiler.  I don't know if these
are able to compile FFmpeg at the moment, but that's beside the point.
On Alpha the DEC/Compaq/HP compiler should compile FFmpeg just fine.

>>> Besides, the non-gcc part is simply wrong: it assumes a naive unaligned
>>> store will work, and that's false on many architectures.
>>
>> yes, this should be fixed with a #ifdef ARCH_X86 around the code and a
>> slow byte per byte reading for the non gcc non x86 case

Other compilers may have tricks of their own to handle unaligned accesses.
When this is the case, they should be enabled under the appropriate ifdefs.

-- 
M?ns Rullg?rd
mru at inprovide.com