[Ffmpeg-devel] [PATCH] macro redefinition warning fix

Diego Biurrun diego
Tue Oct 31 11:51:39 CET 2006


On Mon, Oct 30, 2006 at 09:59:15AM +0100, Diego Biurrun wrote:
> Here's a fix for the following warning:
> 
> ppc/mpegvideo_altivec.c:34:1: warning: "SWAP" redefined
> In file included from ppc/../dsputil.h:33,
>                  from ppc/mpegvideo_altivec.c:26:
> /Users/diegobiurrun/src/ffmpeg/libavutil/common.h:201:1: warning: this is the location of the previous definition
> 
> I renamed the SWAP macro to SWAP_ALTIVEC.
> 
> Probably a better solution would be to rename the SWAP macro in
> libavutil/common.h to FFSWAP.  Thoughts?

I prefer the latter solution, SWAP is bound to be a very common macro
name.  I'll implement this tomorrow, sending a patch for this trivial
change is useless...

Diego




More information about the ffmpeg-devel mailing list