[Ffmpeg-devel] [PATCH] MJPEG wrongly displayed withverticalYUV422

[Michael Niedermayer]

Hi

On Mon, Oct 30, 2006 at 11:09:04PM +0100, V?ctor Paesa wrote:
> > Hi Guillaume,
> >
> > On Mon, 2006-10-30 at 22:31 +0100, Guillaume POIRIER wrote:
> > [...]
> >> > Regression tests do not work when swscaler is enabled. This is a known
> >> > issue (not easily fixable, since fixing it would require having 2
> >> > different copies of the .ref files)
> >>
> >> if we want to track down regression test some day or the other, we
> >> need to have a reference hash.
> >> IMHO, we need to commit one and let the person who runs the regression
> >> tests use the relevant version. Maybe we can refine later on, but
> >> surely having no way to check regression isn't a good idea!
> >>
> >> Now, maybe there are other problems such as: mmx, altivec, etc...
> >> implementations have different rounding and therefore different hash,
> >> which also isn't gonna make things easy.... well...
> > I agree. I tried to find a way to have regression tests working both
> > with and without swscaler, but I could only come up with this patch:
> > http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2006-October/046308.html
> > which is not acceptable (I agree with Diego and Michael). If anyone has
> > better ideas...

yes switch to swscaler by default, and update the checksums iam tempted to 
simply do this, whats holding that up anyway? contacating authors about LGPL?
everyone who didnt awnser yet wont awnser, or is there something else
missing?


> >
> The tests are very sensitive, they require bit exact results, what about
> using a more relaxed criteria, something like if the PSNR is good enough
> then test is passed.

we have PSNR tests too, look more carefull, and no the bitexact tests are
important and PSNR tests alone arent enough

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is