[Ffmpeg-devel] [RFC] IMC decoder

[Kostya]

On Mon, Oct 30, 2006 at 10:59:50AM +0100, Michael Niedermayer wrote:
> Hi
> 
[...]
> 
> [...]
> [...]
> > +        r1 = sin((i * 4.0 + 1.0) / 2048.0 * M_PI * 2.0);
> > +        r2 = cos((i * 4.0 + 1.0) / 2048.0 * M_PI * 2.0);
> 
> forgotten? /2048*2=/1024

Yes
 
> [...]
> > +            tmp = tmp * imc_exp_tab[15 + level];
> > +            tmp2 = tmp2 + q->flcf2 * level;
> 
> *= and += could be used

Done 

> [...]
> > +            if (q->levlCoeffBuf[i] != 16) {
> > +                q->bitsBandT[i] = 5;
> > +                for(j = band_tab[i]; j < band_tab[i+1]; j++) {
> > +                    bitscount += 5;
> > +                    q->CWlengthT[j] = 5;
> > +                }
> > +            } else {
> > +                q->bitsBandT[i] = 0;
> > +                for(j = band_tab[i]; j < band_tab[i+1]; j++) {
> > +                    q->CWlengthT[j] = 0;
> > +                }
> > +            }
> 
> int bits= q->levlCoeffBuf[i] == 16 ? 0 : 5;
> q->bitsBandT[i] = bits;
> for(j = band_tab[i]; j < band_tab[i+1]; j++) {
>     bitscount += bits;
>     q->CWlengthT[j] = bits;
> }

Done

> excpet these minor things patch looks ok

Committed

> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> In the past you could go to a library and read, borrow or copy any book
> Today you'd get arrested for mere telling someone where the library is
>