[Ffmpeg-devel] swscale.h in libavcodec and libswscale

[Luca Abeni]

Hi V?ctor,

On Sun, 2006-10-22 at 20:51 +0200, V?ctor Paesa wrote:
[...]
> >> CFLAGS+=-I$(SRC_PATH)/libswscale $(AMR_CFLAGS)
> >>
> >> Apart from that the patch looks fine to me.
> > Ok, I made this change and I also fixed "make install" (I hope I did it
> > in the proper way). If noone complains, I'll apply this tomorrow.
> >
> Great work, but Cygwin mercyless complains on undefined references
> and swcaler references libavutil so I got these errors:
Ops... Sorry about that; it is a long time that I do not test
compilation with cygwin...

Anyway, is the problem introduced by this patch, or is it already
present in the svn version?
I must be missing something, but I do not see how the patch can cause a
similar error (it basically changes the includes for the non-swscale
case, while you are seeing the problem when compiling with swscale).

[...]
> I added this line on top of your patch:
> ===================================================================
> --- libswscale/Makefile (revision 20371)
> +++ libswscale/Makefile (working copy)
> @@ -7,6 +7,8 @@
>  LIBMAJOR=$(SWSMAJOR)
>  endif
> 
> +EXTRALIBS := -L$(BUILD_ROOT)/libavutil -lavutil$(BUILDSUF)
> +
>  OBJS= swscale.o rgb2rgb.o yuv2rgb.o
>  ifeq ($(TARGET_ALTIVEC),yes)
>  OBJS+=  yuv2rgb_altivec.o
Libavcodec's makefile contains a similar line before "NAME=...", so I
guess this is the correct solution (only, let's add "EXTRALIBS :=" just
before the "NAME=", as in libavcodec).

Diego, do you agree?

Anyway, looking at the fix for this problem it seems to me that this has
always been broken (well, not always: only since my first commit on
libswscale's Makefile).


			Thanks,
				Luca