[Ffmpeg-devel] trouble with multiple headers with the same name

[Michael Niedermayer]

Hi

On Thu, Oct 12, 2006 at 12:00:14PM +0200, Diego Biurrun wrote:
> On Sun, Oct 08, 2006 at 11:38:20PM +0200, Michael Niedermayer wrote:
> > 
> > On Sun, Oct 08, 2006 at 11:23:09PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > > On Sunday, 08 October 2006 at 23:07, Dominik 'Rathann' Mierzejewski wrote:
> > > > 
> > > > There are two headers with the same name: libavutil/internal.h and
> > > > libavcodec/internal.h. I don't know if this is an issue with FFmpeg's or
> > > > MPlayer's buildsystem yet, but even though av_tempfile is declared in
> > > > libavcodec/internal.h and both xvidff.c and xvid_rc.c include "internal.h",
> > > > the one from libavutil instead of the one from current dir gets used,
> > > > resulting in:
> > > > 
> > > > xvidff.c:232: warning: implicit declaration of function ???av_tempfile???
> > > > xvid_rc.c:43: warning: implicit declaration of function ???av_tempfile???
> > > > 
> > > > Hopefully somebody can make some sense out of this. A quick and simple
> > > > solution could be to move av_tempfile from libavcodec/utils.c to libavutil/.
> > 
> > iam against av_tempfile() in libavutil, the problem is in xvid, they shouldnt
> > depend on file IO stuff but instead just pass char* around ...
> 
> Any XviD developers listening?
> 
> In any case this needs to be fixed since internal.h from libavutil is
> used instead of the one from libavcodec.
> 
> I propose renaming libavcodec/internal.h.  Since it is only used in
> xvidff.c and xvid_rc.c I propose xvid_internal.h or something similar.
> Suggestions?

ok but update:
------------
#ifndef INTERNAL_H
#define INTERNAL_H

/**
 * @file internal.h
 * common functions for internal libavcodec use
 */
-------------

too

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is