[Ffmpeg-devel] [PATCH]add codec id for TTA and WavPack in riff.c

[Michael Niedermayer]

Hi

On Fri, Oct 06, 2006 at 07:54:41AM -0700, David Bryant wrote:
> Hi,
> 
> yong wrote:
> >Hi, with this pacth applied,
> >trasncoding tta/wavpack to other audio codec in ffmpeg  will work,
> >playback in ffplay will work too. :)
> >
> >Index: libavformat/riff.c
> >===================================================================
> >--- libavformat/riff.c	(revision 6533)
> >+++ libavformat/riff.c	(working copy)
> >@@ -191,6 +192,8 @@
> >     { CODEC_ID_ADPCM_CT, 0x200 },
> >     { CODEC_ID_ADPCM_SWF, ('S'<<8)+'F' },
> >     { CODEC_ID_TRUESPEECH, 0x22 },
> >+    { CODEC_ID_TTA, MKTAG('T', 'T', 'A', '1') },
> >+    { CODEC_ID_WAVPACK, MKTAG('W', 'V', 'P', 'K') },
> > 
> >     // for NuppelVideo (nuv.c)
> >     { CODEC_ID_PCM_S16LE, MKTAG('R', 'A', 'W', 'A') },
> >
> >
> >  
> I am the developer of WavPack, but I'm very new to ffmpeg and I don't 
> really understand what this does. It is in a list of format ids for the 
> wav container but WavPack in wav is not supported. 

yes but that table is also used for a few other things


> Also, in the wav 
> header those ids are only 16-bit so WVPK can't fit.

and ffmpeg didt check that, it happily truncated ids if there where too long
ive fixed that, ffmpeg will now fail if it ends with a too long id


> I assume that this 
> table means something else in the ffmpeg context, but I could not figure 
> out what (especially since I did not see FLAC in there and I know that's 
> supported).

ive added flac, which fixed mplayer -demuer 35 with *.flac
so yes mplayer + libavformat is one thing which depends on some fourcc
for every format

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is