[Ffmpeg-devel] [patch] idct_mmx_xvid - LGPL license

Diego Biurrun diego
Wed Oct 4 11:18:37 CEST 2006


On Mon, Oct 02, 2006 at 07:01:25PM +0200, Diego Biurrun wrote:
> On Mon, Oct 02, 2006 at 04:01:02PM +0200, Diego Biurrun wrote:
> > On Sun, Oct 01, 2006 at 01:46:32PM +1000, pete wrote:
> > > 
> > > enclosed is an ammendment to the license description of idct_mmx_xvid.c
> > > to grant usage of this file under the LGPL.
> > 
> > I'd say the right way to accomplish this would be to directly change the
> > licensing header to LGPL.
> > 
> > Here is a patch that does that and removes CONFIG_GPL from the places
> > where this code is called.  Unfortunately this breaks the regression
> > tests for reasons I don't fully understand.
> > 
> > Any clues?
> 
> Scratch that, libavtest works fine and the codectest failure appears to
> be unrelated.  So I'll commit this tommorrow.

Yeah, I know, everybody is so used to patches not getting attached that
not even complaints are forthcoming anymore...

Diego
-------------- next part --------------
Index: libavcodec/i386/idct_mmx_xvid.c
===================================================================
--- libavcodec/i386/idct_mmx_xvid.c	(revision 6530)
+++ libavcodec/i386/idct_mmx_xvid.c	(working copy)
@@ -5,20 +5,19 @@
 // *
 // *  Copyright(C) 2001 Peter Ross <pross at xvid.org>
 // *
-// *  This program is free software; you can redistribute it and/or modify it
-// *  under the terms of the GNU General Public License as published by
-// *  the Free Software Foundation; either version 2 of the License, or
-// *  (at your option) any later version.
+// * This library is free software; you can redistribute it and/or
+// * modify it under the terms of the GNU Lesser General Public
+// * License as published by the Free Software Foundation; either
+// * version 2 of the License, or (at your option) any later version.
 // *
-// *  This program is distributed in the hope that it will be useful,
-// *  but WITHOUT ANY WARRANTY; without even the implied warranty of
-// *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// *  GNU General Public License for more details.
+// * This library is distributed in the hope that it will be useful,
+// * but WITHOUT ANY WARRANTY; without even the implied warranty of
+// * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+// * Lesser General Public License for more details.
 // *
-// *  You should have received a copy of the GNU General Public License
-// *  along with this program; if not, write to the Free Software Foundation,
-// *  Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-//
+// * You should have received a copy of the GNU Lesser General Public License
+// * along with this library; if not, write to the Free Software Foundation,
+// * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 // *
 // * $Id$
 // *
Index: libavcodec/i386/dsputil_mmx.c
===================================================================
--- libavcodec/i386/dsputil_mmx.c	(revision 6530)
+++ libavcodec/i386/dsputil_mmx.c	(working copy)
@@ -2742,7 +2742,6 @@
     ff_vp3_idct_mmx(block);
     add_pixels_clamped_mmx(block, dest, line_size);
 }
-#ifdef CONFIG_GPL
 static void ff_idct_xvid_mmx_put(uint8_t *dest, int line_size, DCTELEM *block)
 {
     ff_idct_xvid_mmx (block);
@@ -2763,7 +2762,6 @@
     ff_idct_xvid_mmx2 (block);
     add_pixels_clamped_mmx(block, dest, line_size);
 }
-#endif
 
 static void vorbis_inverse_coupling_3dnow(float *mag, float *ang, int blocksize)
 {
@@ -3121,7 +3119,6 @@
                 }
             }else if(idct_algo==FF_IDCT_CAVS){
                     c->idct_permutation_type= FF_TRANSPOSE_IDCT_PERM;
-#ifdef CONFIG_GPL
             }else if(idct_algo==FF_IDCT_XVIDMMX){
                 if(mm_flags & MM_MMXEXT){
                     c->idct_put= ff_idct_xvid_mmx2_put;
@@ -3132,7 +3129,6 @@
                     c->idct_add= ff_idct_xvid_mmx_add;
                     c->idct    = ff_idct_xvid_mmx;
                 }
-#endif
             }
         }
 
Index: libavcodec/Makefile
===================================================================
--- libavcodec/Makefile	(revision 6530)
+++ libavcodec/Makefile	(working copy)
@@ -296,9 +296,10 @@
 	i386/dsputil_mmx.o i386/mpegvideo_mmx.o \
 	i386/motion_est_mmx.o \
 	i386/simple_idct_mmx.o i386/fft_sse.o i386/vp3dsp_mmx.o \
-	i386/vp3dsp_sse2.o i386/fft_3dn.o i386/fft_3dn2.o i386/snowdsp_mmx.o
+	i386/vp3dsp_sse2.o i386/fft_3dn.o i386/fft_3dn2.o i386/snowdsp_mmx.o \
+	i386/idct_mmx_xvid.o
 ifeq ($(CONFIG_GPL),yes)
-OBJS += i386/idct_mmx.o i386/idct_mmx_xvid.o
+OBJS += i386/idct_mmx.o
 endif
 ifeq ($(CONFIG_CAVS_DECODER),yes)
 OBJS += i386/cavsdsp_mmx.o



More information about the ffmpeg-devel mailing list