[Ffmpeg-devel] [PATCH] Which Vorbis encoder by default

[Aurelien Jacobs]

On Mon, 2 Oct 2006 17:13:08 +0200
Oded Shimon <ods15 at ods15.dyndns.org> wrote:

> On Mon, Oct 02, 2006 at 04:53:23PM +0200, Oded Shimon wrote:
> > Right now, the only way to get ffmpeg to use the library vorbis encoder is 
> > to manually disable the native one.
> > I'm thinking maybe the default vorbis encoder should be the library one, 
> > and the way to choose the native one would be with -acodec vorbis_native . 
> > You'd still need to use --enable-libogg --enable-vorbis to get the library 
> > one, just like before... But if you didn't, there would be no "vorbis" 
> > encoder at all, just "vorbis_native".
> 
> Different patch - there will always be a "vorbis" encoder, which one it is 
> depends on if ffmpeg was compiled with --enable-vorbis or not (which is 
> now a misleading option name btw, it should be --enable-libvorbis), and 
> there will always be a "vorbis_native" encoder. Is this acceptable?
> 
> - ods15
> 
> Index: avcodec.h
> ===================================================================
> --- avcodec.h	(revision 6525)
> +++ avcodec.h	(working copy)
> @@ -203,6 +203,7 @@
>      CODEC_ID_AC3,
>      CODEC_ID_DTS,
>      CODEC_ID_VORBIS,
> +    CODEC_ID_VORBIS_NATIVE,
>      CODEC_ID_DVAUDIO,
>      CODEC_ID_WMAV1,
>      CODEC_ID_WMAV2,

Don't add a new codec in the middle of the enum. This breaks the ABI.

Aurel