[Ffmpeg-devel] [PATCH] Vorbis Encoder

[Michael Niedermayer]

Hi

On Sun, Oct 01, 2006 at 09:41:21PM +0200, Oded Shimon wrote:
> On Sun, Oct 01, 2006 at 09:19:56PM +0200, Michael Niedermayer wrote:
> > On Sun, Oct 01, 2006 at 07:42:39PM +0200, Oded Shimon wrote:
> > > On Sun, Oct 01, 2006 at 05:43:47PM +0200, Michael Niedermayer wrote:
> > > > On Sun, Oct 01, 2006 at 02:04:59PM +0200, Oded Shimon wrote:
> > > > >     lx = 0;
> > > > >     ly = posts[0] * fc->multiplier; // sorted 0 is still 0
> > > > >     for (i = 1; i < fc->values; i++) {
> > > > >         int pos = fc->list[i].sort;
> > > > >         if (coded[pos]) {
> > > > >             render_line(lx, ly, fc->list[pos].x, posts[pos] * fc->multiplier, floor, samples);
> > > > >             lx = fc->list[pos].x;
> > > > >             ly = posts[pos] * fc->multiplier;
> > > > >         }
> > > > >         if (lx >= samples) break;
> > > > >     }
> > > > >     if (lx < samples) render_line(lx, ly, samples, ly, floor, samples);
> > > > 
> > > > this looks duplicated from the end of vorbis_floor1_decode()
> > > 
> > > fixed
> > > 
> > > ...
> > > 
> > > anything else? :)
> > 
> > regression tests, rate distortion optimal encoding, suport for making coffee
> 
> Should I really add regression tests? it's still in heavy development, 
> this would be nothing but annoying. (psy needs to be tuned, or done at 
> all. which btw, i have no clue about :( any volunteers?).

well regression tests protect you against unintended changes, if you dont
want them yet thats fine too ...


> 
> Hmm, the coffee thing seems fairly trivial. At least easier than getting 
> this encoder into ffmpeg :)

:)


[...]
> > except these iam ok with seeing this applied to svn, it still needs
> > some cleanup work but that can be done in ffmpeg-svn
> 
> I'll commit tommorrow morning...

ok, just dont forget to test the script if you didnt do it yet 3 times at
least, also consider that some commands might fail (due to conflicts
from other commits ...)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is