[Ffmpeg-devel] [PATCH] asf.[ch] patch to handle mms streaming....
Michael Niedermayer
michaelni
Wed Nov 29 23:15:00 CET 2006
Hi
On Tue, Nov 28, 2006 at 06:40:48PM -0600, Ryan Martell wrote:
[...]
> >and maybe you could just replace the data_object_size == -1 cases by
> > == 0 this would avoid haveing to set it to the non-default -1
>
> <rant>
> the asf code has all sorts of random stuff in it; variables that are
> assigned to and never read, variables that are read from but not
> really assigned to (except by clearing to zero), etc. (I found this
> out when I initially just ripped out the read header and the read
> packet for a different approach to mms streaming)
>
> for example, I don't think this is right:
> if((url_ftell(&s->pb) + ret - s->data_offset) % asf-
> >packet_size)
> ret += asf->packet_size - ((url_ftell(&s->pb) + ret
> - s->data_offset) % asf->packet_size);
> as nothing in this file assigns anything to s->data_offset.
its assigned in utils.c
> I think
> they meant to use asf->data_offset.
asf->data_offset and AVFormatContext->data_offset seem to be redundant,
the asf-> variant should be droped if they are
a seperate patch which cleans this and other things up would certainly
be welcome
[...]
> So here's a smaller, tighter patch.
looks ok
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is
More information about the ffmpeg-devel
mailing list