[Ffmpeg-devel] [FWD] [PATCH] immediate decoding of dvd stills

[Michael Niedermayer]

Hi

On Sat, Nov 25, 2006 at 03:13:43PM +0100, Nico Sabbi wrote:
> Some time ago someone posted this small patch to permit decoding dvd 
> still images
> without setting LOW_DELAY; unfortunately it seems the patch was forgotten
> 
> Is it ok to commit?
> If not, what's the right way to proceed?
> 

> Index: libavcodec/mpeg12.c
> ===================================================================
> RCS file: /cvsroot/ffmpeg/ffmpeg/libavcodec/mpeg12.c,v
> retrieving revision 1.248
> diff -u -r1.248 mpeg12.c
> --- libavcodec/mpeg12.c	4 Feb 2006 20:32:02 -0000	1.248
> +++ libavcodec/mpeg12.c	24 Feb 2006 13:15:29 -0000
> @@ -2983,6 +2983,17 @@
>          }
>      }
>  
> +    /* look for SEQ_END_CODE at the last data in this buffer*/
> +    /* dvd's won't send the next frame start on still images*/
> +    /* state should hold the last startcode if one was found above*/
> +    /* i will point to the position after that startcode */
> +    if(!pc->frame_start_found){

this could be a else after the if(pc->frame_start_found) below


> +      if(state == SEQ_END_CODE){

> +        pc->state=-1;

i this needed?


> +        return i;
> +      }
> +    }

indention is not 4 spaces

> +
>      if(pc->frame_start_found){
>          /* EOF considered as end of frame */
>          if (buf_size == 0)

except these its ok if it works and doesnt breal anything

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is