[Ffmpeg-devel] [PATCH] VC1 decoding of Advanced Profile's b-frames

[Michael Niedermayer]

Hi

On Sat, Nov 25, 2006 at 07:39:19AM +0200, Kostya wrote:
[...]
> > @@ -1801,7 +1826,7 @@
> >      if(v->dqprofile == DQPROFILE_SINGLE_EDGE)                  \
> >          edges = 1 << v->dqsbedge;                              \
> >      else if(v->dqprofile == DQPROFILE_DOUBLE_EDGES)            \
> > -        edges = (3 << v->dqsbedge) % 15;                       \
> > +        edges = (3 << v->dqsbedge) & 15;                       \
> >      else if(v->dqprofile == DQPROFILE_FOUR_EDGES)              \
> >          edges = 15;                                            \
> >      if((edges&1) && !s->mb_x)                                  \
> 
> This is wrong. The purpose of this code is cyclic rotation of
> 0011b, so modulo division is needed.

and that should be documented ideally :)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is